[PATCH] D59296: [pp-trace] Delete -ignore and add generalized -callbacks

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from some small nits. Feel free to fix and commit without further review if you'd like.



================
Comment at: docs/ReleaseNotes.rst:141
+
+- New `-callbacks` option to filter PP callbacks.
----------------
How about: Added a new option, `-callbacks`, to filter preprocessor callbacks; replaces the `-ignore` option.


================
Comment at: pp-trace/PPTrace.cpp:168
+  for (StringRef Pattern : Patterns) {
+    bool Enabled = !Pattern.consume_front("-");
+    if (Expected<GlobPattern> Pat = GlobPattern::create(Pattern))
----------------
Do you want to trim the pattern, in case the user specifies a pattern with whitespace around the commas? e.g., `-callbacks 'foo, bar,    baz'` (You should add a test for this as well.)


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59296/new/

https://reviews.llvm.org/D59296