[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

[Roman Lebedev via Phabricator via cfe-commits]

lebedev.ri added inline comments.


================
Comment at: unittests/clang-tidy/AddConstTest.cpp:733
+  StringRef T = "template <typename T> void f(T v) \n";
+  StringRef S = "{ T target = v; }";
+  auto Cat = [&T](StringRef S) { return (T + S).str(); };
----------------
lebedev.ri wrote:
> JonasToth wrote:
> > alexfh wrote:
> > > It would be interesting to see test cases with multiple instantiations of the template the fix applies to.
> > I added test for a template function with many instantiations, but there should not be a difference between the instantiations, because only the original code would be transformed, and there the 'how it looks' counts, so in this case it will be treated as a value.
> > Did I misinterpret your question?
> How about https://en.cppreference.com/w/cpp/language/function_template#Explicit_instantiation ?
> I don't see any tests for that.
Also, is there any test coverage missing for 
https://en.cppreference.com/w/cpp/language/template_specialization
and
https://en.cppreference.com/w/cpp/language/partial_specialization
?


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54395/new/

https://reviews.llvm.org/D54395