[PATCH] D59463: [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Mar 16 11:53:17 PDT 2019


aaron.ballman added inline comments.


================
Comment at: include/clang/ASTMatchers/ASTMatchers.h:6421
+///
+/// Prerequisite: the executable directive must not be standalone directive.
+///
----------------
What happens if this prereq is not met? Does the matcher return false, or does it do something worse (like assert)?


================
Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:513-515
+  REGISTER_MATCHER(isStandaloneDirective);
+  REGISTER_MATCHER(isOMPStructuredBlock);
+  REGISTER_MATCHER(hasStructuredBlock);
----------------
Alphabetical order, please.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59463/new/

https://reviews.llvm.org/D59463





More information about the cfe-commits mailing list