[PATCH] D59316: [HIP-Clang] propagate -mllvm options to opt and llc

Fri Mar 15 12:09:56 PDT 2019

arsenm added a comment.

In D59316#1429580 <https://reviews.llvm.org/D59316#1429580>, @yaxunl wrote:

> Here we are looking at the code which emulates a "linker" for HIP toolchain. The offloading action builder requests the offloading toolchain have a linker, but amdgpu does not have a real linker (ISA level linker), so we have to emulate that. If we have an ISA level linker we can get rid of all these stuff, but I don't think that will happen in short time.

This isn't really true. We do run lld to link the final executable. It also doesn't change that opt and llc should never be involved in the process

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59316/new/

https://reviews.llvm.org/D59316