[PATCH] D59336: [clang-tidy] Disable google-runtime-int in Objective-C++ 🔓

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 15 07:26:22 PDT 2019


aaron.ballman added inline comments.


================
Comment at: clang-tools-extra/test/clang-tidy/google-runtime-int.m:1
+// RUN: clang-tidy -checks=-*,google-runtime-int %s 2>&1 -- -x objective-c | not grep 'warning:\|error:'
+
----------------
We typically use `| count 0` instead of an explicit grep. Also, do you really need to pass `-x objective-c`?


================
Comment at: clang-tools-extra/test/clang-tidy/google-runtime-int.mm:1
+// RUN: clang-tidy -checks=-*,google-runtime-int %s -- -x objective-c++ 2>&1 | not grep 'warning:\|error:'
+
----------------
Given that the contents of the file are the same, I would just add this RUN line to the previous test case (changing to `| count 0`). You will still need the `-x objective-c++` in that case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59336/new/

https://reviews.llvm.org/D59336





More information about the cfe-commits mailing list