[PATCH] D58880: [WIP] [Looking for API feedback] [clangd] Type hierarchy subtypes

Thu Mar 14 22:31:29 PDT 2019

nridge added a comment.

In D58880#1422494 <https://reviews.llvm.org/D58880#1422494>, @kadircet wrote:

> Hi Nathan,
>
> I would also suggest splitting up current changes so that we can start reviewing them, which might result in other changes in your planned changes and help reduce duplicate work both on our and your side.
>  [...]
>
> As for splitting changes I would suggest something like:
>
> - RelationSlab
> - Serialization/Deserialization of the RelationSlab
> - Integrating RelationSlab with SymbolCollector
> - Adding queries to index structures(memindex, dex, mergedindex etc.)
> - Surfacing those queries through typehierarchy request

Thanks. The proposed split looks good to me. I've posted the first patch here: https://reviews.llvm.org/D59407

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58880/new/

https://reviews.llvm.org/D58880