[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

[Nico Weber via Phabricator via cfe-commits]

thakis marked 2 inline comments as done.
thakis added inline comments.


================
Comment at: clang/test/Parser/objc-static-assert.m:29
+struct S {
+  @defs(A);
+};
----------------
aaron.ballman wrote:
> Given that static assertions are member declarations of a struct, should this "replay" the static asserts from the interface (including failing the assertions)?
This only works in the old fragile abi and is unsupported in "modern" (8 year old) objc, and it was used very rarely even back then. I don't think we need to do anything about this other than not crashing.


================
Comment at: clang/test/Parser/objc-static-assert.mm:4
+
+#if !__has_feature(objc_c_static_assert)
+#error failed
----------------
aaron.ballman wrote:
> Why do we expect `objc_c_static_assert` to be a supported feature in ObjC++? I would have expected this as an extension, but not a feature.
Thanks for catching this, looks I forgot to re-run the .mm test after changing Features.def :-( Fixed now in r356154.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59223/new/

https://reviews.llvm.org/D59223