[PATCH] D55044: [clang-tidy] check for Abseil make_unique

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 14 00:40:54 PDT 2019


MyDeveloperDay added inline comments.


================
Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:163
+  // Conservatively disable for list initializations
+  if (UseLegacyFunction && New->getInitializationStyle() == CXXNewExpr::ListInit) {
+    return;
----------------
elide the braces


================
Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:237
+  // Conservatively disable for list initializations
+  if (UseLegacyFunction && New->getInitializationStyle() == CXXNewExpr::ListInit) {
+    return;
----------------
elide the braces


================
Comment at: docs/clang-tidy/checks/abseil-make-unique.rst:6
+abseil-make-unique
+============
+
----------------
the ==== length needs to match the text above it


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55044/new/

https://reviews.llvm.org/D55044





More information about the cfe-commits mailing list