[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check
MyDeveloperDay via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Mar 14 00:37:08 PDT 2019
MyDeveloperDay added inline comments.
================
Comment at: clang-tidy/abseil/WrapUniqueCheck.cpp:7
+// License. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
----------------
License as above
================
Comment at: clang-tidy/abseil/WrapUniqueCheck.cpp:77
+ return;
+ }
+
----------------
we don't put braces on small lines, just
```
if (Cons->isListInitialization())
return;
```
================
Comment at: clang-tidy/abseil/WrapUniqueCheck.h:6
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
----------------
this is the wrong license wording now (its changed recently..) check out the other files in trunk
but its something like this....
```
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
```
================
Comment at: docs/clang-tidy/checks/abseil-wrap-unique.rst:10
+.. code-block:: c++
+ class A {
+ public:
----------------
there is normally a newline after a `code-block`
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57435/new/
https://reviews.llvm.org/D57435
More information about the cfe-commits
mailing list