[PATCH] D59279: [Analyzer] Checker for non-determinism caused by iteration of unordered container of pointers

[Kristóf Umann via Phabricator via cfe-commits]

Szelethus requested changes to this revision.
Szelethus added a reviewer: baloghadamsoftware.
Szelethus added a comment.
This revision now requires changes to proceed.

Code is great, idea's great, so green light on my part, but maybe we should allow some folks who are more knowledgeable on AST matching to have a say in this.

The obvious question, why not implement this in clang-tidy? I have nothing against landing this in the static analyzer, just curious.

Please also add some doc to `docs/analyzer/checkers.rst`.



================
Comment at: lib/StaticAnalyzer/Checkers/PointerIterationChecker.cpp:5-6
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
----------------
Uh-oh, we changed licence not long ago, and your last patch also landed with the incorrect header -- could you please fix them?


================
Comment at: test/Analysis/ptr-iter.cpp:1
+// RUN: %clang_analyze_cc1 -analyzer-checker=core,alpha.nondeterminism.PointerIteration %s -analyzer-output=text -verify
+
----------------
```

// RUN: %clang_analyze_cc1 %s -analyzer-output=text -verify \
// RUN:   -analyzer-checker=core,alpha.nondeterminism.PointerIteration
```


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59279/new/

https://reviews.llvm.org/D59279