[PATCH] D45978: dllexport const variables must have external linkage.

Mon Mar 11 10:53:56 PDT 2019

zahiraam marked 6 inline comments as done.
zahiraam added inline comments.

================
Comment at: test/SemaCXX/dllexport.cpp:72-74
+#ifndef MS
 namespace    { __declspec(dllexport) int InternalGlobal; } // expected-error{{'(anonymous namespace)::InternalGlobal' must have external linkage when declared 'dllexport'}}
+#endif
----------------
aaron.ballman wrote:
> I don't have a copy of mingw handy -- can you test that this behavior matches the behavior when targeting mingw32 with GCC? Might also be a good idea to test cygwin as a target as well. I would have thought that they would behave the same as MSVC, but I can't easily test it myself.
Tested it with a set of combinations. The test is passing... 

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D45978/new/

https://reviews.llvm.org/D45978