[PATCH] D58897: [ASTImporter] Make ODR error handling configurable
Aleksei Sidorin via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Mar 11 00:34:25 PDT 2019
a_sidorin added a comment.
Hi Gabor,
This patch LGTM mostly, but there is a comment inline.
================
Comment at: include/clang/AST/ASTStructuralEquivalence.h:81
EqKind(EqKind), StrictTypeSpelling(StrictTypeSpelling),
- ErrorOnTagTypeMismatch(ErrorOnTagTypeMismatch), Complain(Complain) {}
+ Complain(Complain), ErrorOnTagTypeMismatch(ErrorOnTagTypeMismatch) {}
----------------
I see the argument order change but I don't see any callers changed. Do we really need this order change?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58897/new/
https://reviews.llvm.org/D58897
More information about the cfe-commits
mailing list