[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option
MyDeveloperDay via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Mar 10 05:35:31 PDT 2019
MyDeveloperDay added a comment.
In D55170#1423798 <https://reviews.llvm.org/D55170#1423798>, @reuk wrote:
> Thanks for the review, and for approving this PR. It's very much appreciated!
>
> I don't have merge rights - could someone commit this for me please?
I'd actively encourage you to go get commit access, I think its much better when the commit comes from the author.
There just isn't enough people actively involved in clang-format (and other tools) for us to get reviews even looked at (even for defects), we need more people involved fixing defects and doing reviews, getting commit access shows an intent to fix anything in that comes from your own review which is one of the things the code owners push as being an objection to adding more code.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55170/new/
https://reviews.llvm.org/D55170
More information about the cfe-commits
mailing list