[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

Shoaib Meenai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 8 17:17:54 PST 2019


smeenai added inline comments.


================
Comment at: clang/test/Driver/linux-per-target-runtime-dir.c:15
 // CHECK-PER-TARGET-RUNTIME: "--sysroot=[[SYSROOT]]"
+// CHECK-PER-TARGET-RUNTIME: "-L{{.*}}{{/|\\\\}}..{{/|\\\\}}lib{{/|\\\\}}x86_64-linux-gnu"
 // CHECK-PER-TARGET-RUNTIME: "-L[[RESDIR]]{{/|\\\\}}x86_64-linux-gnu{{/|\\\\}}lib"
----------------
phosek wrote:
> smeenai wrote:
> > Shouldn't this have the `clang` component now?
> I haven't changed the location of headers, only libraries. Do you think we should move libc++ headers into `clang` subdirectory inside `include` as well?
This is `-L`, so it's the search path for the libraries, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59168/new/

https://reviews.llvm.org/D59168





More information about the cfe-commits mailing list