[PATCH] D59048: Add AIX Target Info

Fri Mar 8 15:12:43 PST 2019

hubert.reinterpretcast added inline comments.

================
Comment at: clang/lib/Basic/Targets/OSTargets.h:640
+
+    // Define _WCHAR_T when it is a fundamental type (i.e., for C++ without -fno-wchar).
+    if (Opts.CPlusPlus && Opts.WChar) {
----------------
Line is longer than 80 characters. Please split it.

================
Comment at: clang/test/CodeGen/arm-aapcs-zerolength-bitfield.c:1
 // REQUIRES: arm-registered-target
 // RUN: %clang_cc1 -target-abi aapcs -triple armv7-apple-darwin10 %s -verify
----------------
Given the requirement for `arm-registered-target`, is the file actually run whenever we intend it to be? Also, a note re: the existing test: This does not seem to be a CodeGen test; indeed, it is effective even with `-fsyntax-only`. It seems this should be moved to `clang/test/Sema`.

However, not all of the cases are common anyway. We will later need to post changes that implement AIX's 4-byte storage units for bit-fields. I think we should leave this file alone for the purposes of this patch.

================
Comment at: clang/test/Preprocessor/init.c:7027
+// PPC-AIX:#define _IBMR2 1
+// PPC-AIX:#define _LONG_LONG 1
+// PPC-AIX:#define _POWER 1
----------------
Add a check that `_LP64` is not defined under the 32-bit mode. Similarly for `__LP64__` and `__64BIT__`. Other targets also check for the presence or absence of `_ILP32` and `__ILP32__`, so we probably should do the same.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59048/new/

https://reviews.llvm.org/D59048