r352930 - [WebAssembly] Add an import_field function attribute

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 8 14:06:14 PST 2019


On Wed, Feb 6, 2019 at 12:43 AM Dan Gohman <sunfish at mozilla.com> wrote:
>
>
>
> On Tue, Feb 5, 2019 at 11:20 AM Aaron Ballman <aaron at aaronballman.com> wrote:
>>
>> On Fri, Feb 1, 2019 at 8:27 PM Dan Gohman <sunfish at mozilla.com> wrote:
>> >
>> >
>> >  Indeed, and the existing import_module attribute needs these tests as well. I'll write some and add them in a follow-up patch.
>> >
>> > Thanks for the review!
>>
>> Any time! I haven't seen that follow-up patch yet though; did it fall
>> off your radar?
>
>
> Yes, it's still on my radar.

It's been a month and it still seems like this hasn't been taken care
of. The usual expectation is to handle post-commit feedback
"immediately". Can you please address these concerns?

~Aaron

>
> Dan
>


More information about the cfe-commits mailing list