[PATCH] D59038: [8.0 Regression] Fix handling of `__builtin_constant_p` inside the enable_if attribute.

Hans Wennborg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 8 10:11:08 PST 2019


hans added a comment.

In D59038#1422890 <https://reviews.llvm.org/D59038#1422890>, @rsmith wrote:

> LGTM, and I think this is safe enough to take for Clang 8.


Do you think the severity is high enough to spin another release candidate?

My concern is that since this didn't show up in testing until now, which I guess is quite a while after it regressed, maybe it's not important enough to delay the already late release? Also it sounds like it isn't completely fixed yet..


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59038/new/

https://reviews.llvm.org/D59038





More information about the cfe-commits mailing list