[PATCH] D59103: [clang-tidy] New checker bugprone-incomplete-comparison-operator

Kalle Huttunen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 8 06:30:21 PST 2019


kallehuttunen added a comment.

I found this checker to be useful in the code base I initially developed it for, but the usage of comparison operators there is pretty much limited to comparing simple aggregate types. It's true that this checker can produce lots of false positives, maybe too much to be included to clang-tidy proper.

@JonasToth 's proposal is interesting. Overall I think the "modernize-use-defaulted-spaceship-op" check would be much more complex than this one, but I guess the `FieldAccessVisitor` could be used as a building block.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59103/new/

https://reviews.llvm.org/D59103





More information about the cfe-commits mailing list