[PATCH] D45978: dllexport const variables must have external linkage.
Zahira Ammarguellat via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Mar 8 04:36:12 PST 2019
zahiraam added inline comments.
================
Comment at: lib/Sema/SemaDecl.cpp:5975-5977
+ if ((!ND.isExternallyVisible() &&
+ (!isAnonymousNS || !(VD && VD->hasInit()))) ||
+ (VD && VD->isStaticLocal())) {
----------------
aaron.ballman wrote:
> This used to unconditionally warn, but now has predicates -- should this still warn when not in MSVC mode?
Please see new version of code.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D45978/new/
https://reviews.llvm.org/D45978
More information about the cfe-commits
mailing list