[PATCH] D59094: [ARM] Fix bug 39982 - pcs("aapcs-vfp") is not consistent

Fri Mar 8 02:58:27 PST 2019

carwil added a comment.

In D59094#1421893 <https://reviews.llvm.org/D59094#1421893>, @efriedma wrote:

> Not sure how to write a testcase off the top of my head... have you tried homogeneous aggregates with more than two elements?

Good catch! Seems like if we surpass "isHomogeneousAggregateSmallEnough" (4), it's no longer classfied as an aggregate and so doesn't benefit from this fix. I'll see if I can work out a way to catch that as well.

> It looks like every call to getABIKind() is doing the wrong thing; I'm worried that's going to lead to some sort of subtle miscompile without some sort of centralized fix to compute the correct calling convention for every place that checks it.

Agreed. It would be much better if this determined the ABI on context. That said, it doesn't look like that's going to be trivial to achieve...

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59094/new/

https://reviews.llvm.org/D59094