[PATCH] D58729: Emit boxed expression as a compile-time constant if the expression inside the parentheses is a string literal

[Akira Hatanaka via Phabricator via cfe-commits]

ahatanak added inline comments.


================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:922
+def warn_objc_boxing_invalid_utf8_string : Warning<
+  "string is ill-formed as UTF-8 and will become a null NSString* when boxed">,
+  InGroup<ObjCBoxing>;
----------------
rjmccall wrote:
> Might as well use the `NSStringPointer` type we stash on Sema so that this will be the right type even in more obscure environments.
I wasn't exactly sure when `NSStringPointer` can be anything other than `NSString *`.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58729/new/

https://reviews.llvm.org/D58729