r355489 - clang-cl: Parse /Qspectre and a few other missing options (PR40964)

[Hans Wennborg via cfe-commits]

Yes, we warn about them being unused.

On Thu, Mar 7, 2019 at 21:59 Nico Weber via cfe-commits <
cfe-commits at lists.llvm.org> wrote:

> Do we warn "ignoring flag" or something like that for these, or are these
> now silently ignored?
>
> On Wed, Mar 6, 2019 at 4:37 AM Hans Wennborg via cfe-commits <
> cfe-commits at lists.llvm.org> wrote:
>
>> Author: hans
>> Date: Wed Mar  6 01:38:04 2019
>> New Revision: 355489
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=355489&view=rev
>> Log:
>> clang-cl: Parse /Qspectre and a few other missing options (PR40964)
>>
>> Modified:
>>     cfe/trunk/include/clang/Driver/CLCompatOptions.td
>>     cfe/trunk/test/Driver/cl-options.c
>>
>> Modified: cfe/trunk/include/clang/Driver/CLCompatOptions.td
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/CLCompatOptions.td?rev=355489&r1=355488&r2=355489&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/include/clang/Driver/CLCompatOptions.td (original)
>> +++ cfe/trunk/include/clang/Driver/CLCompatOptions.td Wed Mar  6 01:38:04
>> 2019
>> @@ -394,6 +394,8 @@ def _SLASH_Zo_ : CLIgnoredFlag<"Zo-">;
>>
>>  // Unsupported:
>>
>> +def _SLASH_await : CLFlag<"await">;
>> +def _SLASH_constexpr : CLJoined<"constexpr:">;
>>  def _SLASH_AI : CLJoinedOrSeparate<"AI">;
>>  def _SLASH_Bt : CLFlag<"Bt">;
>>  def _SLASH_Bt_plus : CLFlag<"Bt+">;
>> @@ -429,6 +431,9 @@ def _SLASH_Qfast_transcendentals : CLFla
>>  def _SLASH_QIfist : CLFlag<"QIfist">;
>>  def _SLASH_Qimprecise_fwaits : CLFlag<"Qimprecise_fwaits">;
>>  def _SLASH_Qpar : CLFlag<"Qpar">;
>> +def _SLASH_Qpar_report : CLJoined<"Qpar-report">;
>> +def _SLASH_Qsafe_fp_loads : CLFlag<"Qsafe_fp_loads">;
>> +def _SLASH_Qspectre : CLFlag<"Qspectre">;
>>  def _SLASH_Qvec_report : CLJoined<"Qvec-report">;
>>  def _SLASH_u : CLFlag<"u">;
>>  def _SLASH_V : CLFlag<"V">;
>>
>> Modified: cfe/trunk/test/Driver/cl-options.c
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/cl-options.c?rev=355489&r1=355488&r2=355489&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/test/Driver/cl-options.c (original)
>> +++ cfe/trunk/test/Driver/cl-options.c Wed Mar  6 01:38:04 2019
>> @@ -390,6 +390,8 @@
>>  // Unsupported but parsed options. Check that we don't error on them.
>>  // (/Zs is for syntax-only)
>>  // RUN: %clang_cl /Zs \
>> +// RUN:     /await \
>> +// RUN:     /constexpr:depth1000 /constexpr:backtrace1000
>> /constexpr:steps1000 \
>>  // RUN:     /AIfoo \
>>  // RUN:     /AI foo_does_not_exist \
>>  // RUN:     /Bt \
>> @@ -443,6 +445,9 @@
>>  // RUN:     /QIfist \
>>  // RUN:     /Qimprecise_fwaits \
>>  // RUN:     /Qpar \
>> +// RUN:     /Qpar-report:1 \
>> +// RUN:     /Qsafe_fp_loads \
>> +// RUN:     /Qspectre \
>>  // RUN:     /Qvec-report:2 \
>>  // RUN:     /u \
>>  // RUN:     /V \
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190307/6619a915/attachment.html>