[PATCH] D58530: Add PragmaHandler for MSVC pragma execution_character_set

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 7 12:54:32 PST 2019


thakis added a comment.

Does our serialization machinery serialize these correctly automatically? What happens if you compiler a header saying `execution_character_set_push, "utf-8")` in a header, compile that to a pch, then include that through the pch in a .c file that does pop?

My guess is that this either needs (de)serialization code or a warning when the stack is not empty when a pch is written.

(Examples: https://reviews.llvm.org/rL262493 https://reviews.llvm.org/rL262539 -- the latter one is probably a better example)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58530/new/

https://reviews.llvm.org/D58530





More information about the cfe-commits mailing list