[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet marked an inline comment as done.
kadircet added inline comments.


================
Comment at: clangd/GlobalCompilationDatabase.cpp:24
                      llvm::StringRef ResourceDir) {
+  // Clangd does not generate dependency file.
+  Cmd.CommandLine = tooling::getClangStripDependencyFileAdjuster()(
----------------
gribozavr wrote:
> Please don't duplicate code in comments. Explain why it shouldn't generate the dependency files, or drop the comment.
> 
> 
I am saying we are stripping "dependecy file related" commands, because clangd is not producing them. 
I feel like this provides the cause of the following statement, not replicates it. Becuase the following statement just says strip "dependency file related" commands.

But happy to drop the comment if you insist.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59086/new/

https://reviews.llvm.org/D59086