[PATCH] D59054: [analyzer] C++17: PR40022: Support aggregate initialization with compound values in presence of base classes.

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh added a comment.

LG in general.  A couple of comments.



================
Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:2348
+    // Virtual bases still aren't allowed. Multiple bases are fine though.
+    for (auto B : CRD->bases()) {
+      assert(B.isVirtual() == false);
----------------
Should this be `const auto&`?


================
Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:2349
+    for (auto B : CRD->bases()) {
+      assert(B.isVirtual() == false);
+
----------------
`!B.isVirtual()`

Consider also adding `&& "more details about this assertion"`.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59054/new/

https://reviews.llvm.org/D59054