[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

Nick Desaulniers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 6 15:43:31 PST 2019


nickdesaulniers added a comment.

> which is making things hard for the folks testing this with the Linux kernel and needing to apply this patch themselves.

If we can get inlining of callbr working first before landing this, then all of our CI won't go immediately red (as it would from landing this first, then getting inlining support).  Otherwise, we'll have to come up with hacks in the kernel to keep the CI green (I have one for x86.  The one for aarch64 quickly became infeasible).

I'm anxious for this to land, and the rebases are work indeed.  But if we can just wait a little longer and get inlining support working, then land this, it will be much less painful than the other way around.

I'm focused on inlining support in https://reviews.llvm.org/D58260 (which doesn't look like much now, but I have changes locally and have been actively working on it this week).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56571/new/

https://reviews.llvm.org/D56571





More information about the cfe-commits mailing list