[PATCH] D39050: Add index-while-building support to Clang

[Argyrios Kyrtzidis via Phabricator via cfe-commits]

akyrtzi added inline comments.


================
Comment at: include/clang/Frontend/FrontendOptions.h:380
+  /// Whether to ignore system files when writing out index data
+  unsigned IndexIgnoreSystemSymbols : 1;
+  /// Whether to include the codegen name of symbols in the index data
----------------
gribozavr wrote:
> Would it make more sense to flip this boolean to positive?  "IndexIncludeSystemSymbols"?
@jkorous I noticed this name can be misleading, it may seem as if what this does is "avoid indexing system symbol occurrences" but what it actually does is "avoid indexing symbol occurrences from system files". We should rename it to "IndexIgnoreSystemHeaders" or "IndexIncludeSystemHeaders" per Dmitri's suggestion.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D39050/new/

https://reviews.llvm.org/D39050