[PATCH] D59028: [OpenMP] Enable on device linking with NVLINK to ignore dynamic libraries

[Alexey Bataev via Phabricator via cfe-commits]

ABataev added inline comments.


================
Comment at: lib/Driver/ToolChains/Cuda.cpp:707
       CmdArgs.push_back(StaticLibName);
+    } else if (OrigInputFileName.endswith(".so")) {
+      // Only static libraries are supported.
----------------
gtbercea wrote:
> ABataev wrote:
> > gtbercea wrote:
> > > ABataev wrote:
> > > > gtbercea wrote:
> > > > > ABataev wrote:
> > > > > > I would suggest to use `types::lookupTypeForExtension` function and compare the result with the `types::TY_Object`.
> > > > > Isn't that too broad? I only want .so files.
> > > > I don't think nvlink supports anything else except for objects. Also, in future, we could extend it if it is required.
> > > But won't this exclude .o files too? I don't want to ignore those.
> > This function returns `TY_Object` for `.o` and `.obj` extensions (on Windows)
> Oh now I think I understand what you mean. You mean ignore everything that's not a TY_Object? That doesn't work here because I am looking at the original input file name.
Yes, but you can use `types::lookupTypeForExtension` function to classify the original input file name.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59028/new/

https://reviews.llvm.org/D59028