[PATCH] D39050: Add index-while-building support to Clang

Mandeep Singh Grang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 6 10:18:23 PST 2019


mgrang added inline comments.


================
Comment at: lib/Index/FileIndexData.cpp:31
+  std::vector<DeclOccurrence> Sorted(Decls);
+  std::sort(Sorted.begin(), Sorted.end());
+  return Sorted;
----------------
Please use range-based llvm::sort instead of std::sort:

```
llvm::sort(Sorted);
```
See https://llvm.org/docs/CodingStandards.html#beware-of-non-deterministic-sorting-order-of-equal-elements


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D39050/new/

https://reviews.llvm.org/D39050





More information about the cfe-commits mailing list