[PATCH] D58894: [analyzer] Handle modification of vars inside an expr with comma operator

[Djordje Todorovic via Phabricator via cfe-commits]

djtodoro marked an inline comment as done.
djtodoro added a comment.

> Nice, i like this!
> I think the test coverage is good.

@lebedev.ri Thanks!

> But what about other equalsNode() that you didn't change?
> Do some of them need this change too?

For sure some of them (maybe all of them) needs usage of the new comma matcher.
I didn't check all of them, for those I checked I've created test cases.
But I agree, it should handle all possible situation.



================
Comment at: lib/Analysis/ExprMutationAnalyzer.cpp:27
 
+AST_MATCHER_P(Expr, skipCommaOps,
+             ast_matchers::internal::Matcher<Expr>, InnerMatcher) {
----------------
lebedev.ri wrote:
> (Can anyone suggest a better name maybe?
> I'm not sure this is the most correct name, but i can't suggest a better alternative.)
Maybe `evalCommaExpr`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58894/new/

https://reviews.llvm.org/D58894