[PATCH] D58930: Add XCOFF triple object format type for AIX
Jason Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 5 15:17:10 PST 2019
jasonliu marked an inline comment as done.
jasonliu added inline comments.
================
Comment at: llvm/lib/MC/MCContext.cpp:165
+ case MCObjectFileInfo::IsXCOFF:
+ // TODO: Need to implement class MCSymbolXCOFF.
+ break;
----------------
JDevlieghere wrote:
> See previous comment.
It is certain that we will need MCSymbolXCOFF. But before we run into cases where we actually need a MCSymbolXCOFF, we could use the generic MCSymbol first for XCOFF platform. So I don't want to put a llvm_unreachable here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58930/new/
https://reviews.llvm.org/D58930
More information about the cfe-commits
mailing list