[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 5 10:52:02 PST 2019


rjmccall added inline comments.


================
Comment at: lib/Sema/SemaCast.cpp:2293
+  // define overlapping address spaces currently.
+  if (Self.getLangOpts().OpenCL) {
+    auto SrcType = SrcExpr.get()->getType();
----------------
Please structure this as an early exit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58346/new/

https://reviews.llvm.org/D58346





More information about the cfe-commits mailing list