[PATCH] D58708: [PR40778] Preserve addr space in Derived to Base cast

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 5 10:37:31 PST 2019


rjmccall added inline comments.


================
Comment at: lib/Sema/SemaExpr.cpp:2666
+                            ? FromType->getPointeeType().getAddressSpace()
+                            : FromType.getAddressSpace());
 
----------------
Please do a `getAs<PointerType>()` into a local and then use that here and below.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58708/new/

https://reviews.llvm.org/D58708





More information about the cfe-commits mailing list