[PATCH] D58060: Fix diagnostic for addr spaces in reference binding

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 5 10:18:12 PST 2019


Anastasia added inline comments.


================
Comment at: test/SemaOpenCLCXX/address-space-references.cl:7
+// can't detect this case and therefore fails.
+//int bar(const unsigned int &i);
+
----------------
ebevhan wrote:
> Is there a reason the declaration is commented out? If it's just a problem with the resolution, wouldn't it still be possible to have the declaration here anyway?
Hmm... actually not at all! I commented it to show that this could work better... but FIXME is good enough to indicate this!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58060/new/

https://reviews.llvm.org/D58060





More information about the cfe-commits mailing list