[PATCH] D58924: Replace clang::FileData with llvm::vfs::Status
Ben Langmuir via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Mar 4 18:13:52 PST 2019
benlangmuir added inline comments.
================
Comment at: clang/lib/Basic/FileManager.cpp:305
+ UFE = &UniqueRealFiles[Status.getUniqueID()];
+ Status = llvm::vfs::Status(
+ Status.getName(), Status.getUniqueID(),
----------------
harlanhaskins wrote:
> benlangmuir wrote:
> > Why copy Status back into Status instead of mutating the relevant fields?
> The fields don't have setters exposed, and I couldn't decide if adding the setters vs. re-constructing a Status was better here. Would it be worth adding setters to the properties in `Status`?
Nah, just go with the code you already wrote. Thanks for the explanation.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58924/new/
https://reviews.llvm.org/D58924
More information about the cfe-commits
mailing list