[PATCH] D58930: Add XCOFF triple object format type for AIX

Hubert Tong via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 4 15:48:31 PST 2019


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/Support/Triple.cpp:537
   return StringSwitch<Triple::ObjectFormatType>(EnvironmentName)
+    // FIXME: We have to put XCOFF before COFF;
+    // perhaps an order-independent pattern matching is desired?
----------------
If the conclusion is that checking XCOFF before COFF is fine, then we should remove the FIXME and just leave a normal comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58930/new/

https://reviews.llvm.org/D58930





More information about the cfe-commits mailing list