[PATCH] D58893: Modules: Invalidate out-of-date PCMs as they're discovered

Bruno Cardoso Lopes via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 4 15:06:21 PST 2019


bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.

Thanks for working on this, the approach & patch LGTM.



================
Comment at: clang/include/clang/Serialization/InMemoryModuleCache.h:37
 
     /// Track the timeline of when this was added to the cache.
+    bool IsFinal = false;
----------------
Now that generation count is gone, update (or remove) this comment?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58893/new/

https://reviews.llvm.org/D58893





More information about the cfe-commits mailing list