[PATCH] D58890: Modules: Rename MemoryBufferCache to InMemoryModuleCache

Bruno Cardoso Lopes via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 4 14:31:57 PST 2019


bruno added a comment.

`InMemoryModuleCache` seems like a way more appropriate name here. Also thanks for improving some of the comments.

> Because of the move to Serialization we can no longer abuse the Preprocessor to forward it to the ASTReader. Besides the rename and file move, that means Preprocessor::Preprocessor has one fewer parameter and ASTReader::ASTReader has one more.

Are there any C api bits that expose preprocessor stuff and also need updates?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58890/new/

https://reviews.llvm.org/D58890





More information about the cfe-commits mailing list