[PATCH] D58751: Order File Instrumentation: add clang support for -forder-file-instrumentation

[Shoaib Meenai via Phabricator via cfe-commits]

smeenai added inline comments.


================
Comment at: lib/Driver/ToolChains/Clang.cpp:5312
+     CmdArgs.push_back("-forder-file-instrumentation");
+     // Enable order file instrumentation when ThinLTO is not on. When ThinLTO is
+     // on, we need to pass these flags as linker flags and that will be handled
----------------
What about full LTO?


================
Comment at: test/Driver/clang_f_opts.c:137
+// CHECK-ORDERFILE-INSTR: "-forder-file-instrumentation"
+// CHECK-ORDERFILE-INSTR: "-enable-order-file-instrumentation"
 
----------------
Can you add a test for not passing this for the ThinLTO case?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58751/new/

https://reviews.llvm.org/D58751