[PATCH] D58885: Variable auto-init: split out small arrays

Alexander Potapenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 4 09:37:12 PST 2019


glider added a comment.

The change itself looks good.
It doesn't seem to regress kernel performance on ARM64. I haven't got to testing on x86 yet, but don't anticipate any problems either.



================
Comment at: lib/CodeGen/CGDecl.cpp:1206
+  bool canDoSingleStore = Ty->isIntOrIntVectorTy() ||
+                          Ty->isPtrOrPtrVectorTy() || Ty->isFPOrFPVectorTy();
+  if (canDoSingleStore) {
----------------
Is the second expression being moved to line 1206 a result of clang-format? Otherwise it'll migrate back at some point.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58885/new/

https://reviews.llvm.org/D58885





More information about the cfe-commits mailing list