[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 4 03:51:58 PST 2019


Anastasia added a comment.

In D58346#1413863 <https://reviews.llvm.org/D58346#1413863>, @rjmccall wrote:

> Hmm.  Yeah, Embedded C allows these casts, so contra my previous comment, I think we can't make them ill-formed outside of OpenCL mode.


Ok, would these rules apply in regular C99 mode then? Do you think I should change anything in the comment about the addr space cast logic here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58346/new/

https://reviews.llvm.org/D58346





More information about the cfe-commits mailing list