[PATCH] D58891: Modules: Add -Rmodule-import

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Mar 3 21:56:03 PST 2019


dexonsmith created this revision.
dexonsmith added reviewers: Bigcheese, bruno, rsmith, vsapsai.
Herald added a subscriber: jdoerfert.

Add a remark for importing modules.  Depending on whether this is a
direct import (into the TU being built by this compiler instance) or
transitive import (into an already-imported module), the diagnostic has
two forms:

  importing module 'Foo' from 'path/to/Foo.pcm'
  importing module 'Foo' into 'Bar' from 'path/to/Foo.pcm'

Also drop a redundant FileCheck invocation in Rmodule-build.m that was
using -Reverything, since the notes from -Rmodule-import were confusing
it.


https://reviews.llvm.org/D58891

Files:
  clang/include/clang/Basic/DiagnosticGroups.td
  clang/include/clang/Basic/DiagnosticSerializationKinds.td
  clang/lib/Serialization/ASTReader.cpp
  clang/test/Modules/Inputs/Rmodule-import/A.h
  clang/test/Modules/Inputs/Rmodule-import/B.h
  clang/test/Modules/Inputs/Rmodule-import/C.h
  clang/test/Modules/Inputs/Rmodule-import/D.h
  clang/test/Modules/Inputs/Rmodule-import/module.modulemap
  clang/test/Modules/Rmodule-build.m
  clang/test/Modules/Rmodule-import.m

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58891.189116.patch
Type: text/x-patch
Size: 6589 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190304/9da4388a/attachment.bin>


More information about the cfe-commits mailing list