r355294 - Modules: Document that ReadASTCore exits its final loop via `return`, NFC
Duncan P. N. Exon Smith via cfe-commits
cfe-commits at lists.llvm.org
Sun Mar 3 12:17:54 PST 2019
Author: dexonsmith
Date: Sun Mar 3 12:17:53 2019
New Revision: 355294
URL: http://llvm.org/viewvc/llvm-project?rev=355294&view=rev
Log:
Modules: Document that ReadASTCore exits its final loop via `return`, NFC
The final loop never breaks. Document that by following it with
llvm_unreachable.
Modified:
cfe/trunk/lib/Serialization/ASTReader.cpp
Modified: cfe/trunk/lib/Serialization/ASTReader.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Serialization/ASTReader.cpp?rev=355294&r1=355293&r2=355294&view=diff
==============================================================================
--- cfe/trunk/lib/Serialization/ASTReader.cpp (original)
+++ cfe/trunk/lib/Serialization/ASTReader.cpp Sun Mar 3 12:17:53 2019
@@ -4257,7 +4257,7 @@ ASTReader::ReadASTCore(StringRef FileNam
}
}
- return Success;
+ llvm_unreachable("unexpected break; expected return");
}
ASTReader::ASTReadResult
More information about the cfe-commits
mailing list