[PATCH] D58811: [clang] Fix misuses of char width to char align

Aleksandr Malykh via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 1 02:11:57 PST 2019


amalykh added a comment.

Currently getCharWidth and getCharAlign functions are hard coded to return 8 in clang with no way to change it for target.
This can be seen in TargetInfo.h file:

  unsigned getCharWidth() const { return 8; } // FIXME
  unsigned getCharAlign() const { return 8; } // FIXME

It means that these functions can be used interchangeably and there will be no test failures because of this, until custom alignment will be supported.
Nevertheless, it will not be possible to


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58811/new/

https://reviews.llvm.org/D58811





More information about the cfe-commits mailing list