[PATCH] D58778: Moved Ref into its own header and implementation file
Eric Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Feb 28 05:31:03 PST 2019
ioeric added inline comments.
================
Comment at: clang-tools-extra/clangd/index/Ref.cpp:1
+#include "Ref.h"
+
----------------
License?
================
Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:14
#include "CodeCompletionStrings.h"
+#include "ExpectedTypes.h"
#include "Logger.h"
----------------
Is this change relevant in this patch?
================
Comment at: clang-tools-extra/clangd/indexer/IndexerMain.cpp:16
#include "index/Serialization.h"
+#include "index/Symbol.h"
#include "index/SymbolCollector.h"
----------------
Maybe also include Ref.h?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58778/new/
https://reviews.llvm.org/D58778
More information about the cfe-commits
mailing list