[PATCH] D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions

Thu Feb 28 04:43:58 PST 2019

JonasToth added a comment.

In D58731#1413498 <https://reviews.llvm.org/D58731#1413498>, @MyDeveloperDay wrote:

> In D58731#1413476 <https://reviews.llvm.org/D58731#1413476>, @lewmpk wrote:
>
> > I'm happy to land this ASAP but I don't have commit rights
>
>
> So one of us could land it for you.. (I've not personally done that before as I'm a bit green too! but I do have commit rights)
>
> Its pretty easy to get commit rights, and given your looking at multiple issues I'd recommend it.. (https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access)

@MyDeveloperDay if you want to try the procedure out, go ahead ;) Otherwise I can land this patch now.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58731/new/

https://reviews.llvm.org/D58731