[PATCH] D58772: [clangd] Enable SuggestMissingIncludes by default.

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 28 03:11:17 PST 2019


ioeric created this revision.
ioeric added a reviewer: kadircet.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov.
Herald added a project: clang.

This seems to work stably now. Turn on by default.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D58772

Files:
  clangd/tool/ClangdMain.cpp


Index: clangd/tool/ClangdMain.cpp
===================================================================
--- clangd/tool/ClangdMain.cpp
+++ clangd/tool/ClangdMain.cpp
@@ -217,7 +217,7 @@
     "suggest-missing-includes",
     llvm::cl::desc("Attempts to fix diagnostic errors caused by missing "
                    "includes using index."),
-    llvm::cl::init(false));
+    llvm::cl::init(true));
 
 namespace {
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58772.188701.patch
Type: text/x-patch
Size: 412 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190228/779b850b/attachment.bin>


More information about the cfe-commits mailing list