[PATCH] D58742: [WebAssembly] Remove uses of ThreadModel

Thomas Lively via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 27 15:46:11 PST 2019


tlively marked an inline comment as done.
tlively added inline comments.


================
Comment at: llvm/test/CodeGen/WebAssembly/atomic-mem-consistency.ll:1
-; RUN: not llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt
+; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt
 ; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt -wasm-disable-explicit-locals -wasm-keep-registers -mattr=+atomics,+sign-ext | FileCheck %s
----------------
sbc100 wrote:
> What did this start passing?   Is it because llc now has the correct default and will lower atomics to non-atomics?  I guess there is no longer a way to make this fail in the way that it did before.. which is good?
Precisely :D


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58742/new/

https://reviews.llvm.org/D58742





More information about the cfe-commits mailing list