[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh added a comment.

A few more comments.



================
Comment at: clang-tidy/utils/FixItHintUtils.cpp:83
+    return (llvm::Twine(' ') +
+            llvm::Twine(DeclSpec::getSpecifierName(Qualifier)))
+        .str();
----------------
The first operand being llvm::Twine is enough for the whole chained concatenation expression to be llvm::Twine.


================
Comment at: unittests/clang-tidy/AddConstTest.cpp:15
+
+template <QualifierTarget CT = QualifierTarget::Pointee,
+          QualifierPolicy CP = QualifierPolicy::Left>
----------------
What's the point of default values of template arguments here?


================
Comment at: unittests/clang-tidy/AddConstTest.cpp:53
+
+// TODO: Template-code
+
----------------
Is this still needed? If yes, please use "FIXME" instead and expand on what exactly is missing or needs to be done.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54395/new/

https://reviews.llvm.org/D54395