[PATCH] D58666: [OpenCL] Undefine cl_intel_planar_yuv extension

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 27 09:57:30 PST 2019


Anastasia added inline comments.


================
Comment at: test/SemaOpenCL/extension-begin.cl:26
+
 #ifndef IMPLICIT_INCLUDE
 #include "extension-begin.h"
----------------
sidorovd wrote:
> Anastasia wrote:
> > Can we also test that macro `my_ext` is not defined here but defined above?
> > 
> > It seems we are not testing anything like this...
> #pragma OPENCL EXTENSION my_ext : begin doesn't define an appropriate macro. And so cl-ext=+my_ext.
But don't you need to expose the definition of it?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58666/new/

https://reviews.llvm.org/D58666





More information about the cfe-commits mailing list